Repository navigation
docs: qualify AGENTS.md gate claims for the ADR 0011 focused path - #2007
Conversation
AGENTS.md claimed the unit coverage gate, the end-to-end suites and the full lint command list run on every PR. Since content-focused validation landed, ci.yml gates those steps and jobs on full validation and skips them when a PR changes only documents, so the agent entry point contradicted the workflow. Restate the three claims as full-validation-path behaviour and name the document-only focused path once. Fixes #2006 Signed-off-by: guide <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "guide" agent while Hive policy required a human checkpoint for that agent. Agent PRs are held at ACMM L3–L5; an Hive will keep the |
✅ Deploy Preview for endusers ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…ng else "Every PR that changes code" undersold the full path: data, generated and mixed changes also take it. Name the authored-document set the classifier accepts and state that every other PR runs the full validation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
|
Pushed 2e4e949: "every PR that changes code" was narrower than ADR 0011, which sends data, generated and mixed changes down the full path too. The prose now names the authored-document set the classifier accepts and states that every other PR takes full validation. Removing hold and queueing. |
![hivecommons-hive[bot]](https://avatars.githubusercontent.com/in/3568013?s=60&v=4){kind=small}
There was a problem hiding this comment.
Verified the three restated claims against .github/workflows/ci.yml at merge-base; all three are accurate. This looks correct to me.
- Coverage gate:
Run unit tests with coverageis gated onenv.FULL_VALIDATION == 'true'(ci.yml:71-72), which is false exactly whenclassifyreportsdocument_only(ci.yml:53-55) — matches "on every PR that changes code". - E2E: the
e2ejob'sifskips it whenneeds.validate.outputs.document_only == 'true'(ci.yml:155-158) — matches the "skipped when a PR changes only documents" note. - Lint: document-only PRs run
runDocumentLint(ci.yml:130-140), which runsprettier --check,cspellandmarkdownlinton the changed documents only (scripts/lib/content-only-ci.mjs:222-228); otherwise the six full commands run (ci.yml:141-150). Matches the rewritten Lint bullet exactly.
One low-severity wording imprecision, not blocking: the new intro sentence says "the changed documents alone are linted and checked against the document contracts." The "alone" is true for linting, but the contract step (Check content contracts, ci.yml:~106) runs tests/docs-contract.test.mjs, which walks the entire docs/ tree (readdirSync recursion at tests/docs-contract.test.mjs:35, suite at :45), not just the changed documents. A follow-up could move "alone" to qualify only the lint clause.
The PR body's claim of disjoint scope from #2004 holds: this diff touches only AGENTS.md.
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88
🔒 Hold-gate integrity: branch changed while hold-gated — fresh review requiredThis PR's branch moved while it sat hold-gated: the head recorded when the hold was applied was Commits not present in the hold-time snapshot (1):
Authors not in the hold-time author set: A human should review the FULL diff at the current head — a rebase or force-push renames every commit, so everything above needs eyes even if it looks familiar. Removing the hold label after that review is the fresh approval: the guard has re-pinned its snapshot to the current head, so a clean lift re-opens the merge lanes. |
Documentation Fix
AGENTS.md— the entry point every agent contributor reads first — stilldescribed the pre-ADR-0011 gate layout: it claimed the unit coverage gate,
the "End-to-end tests" check and the full six-command lint list run on
every PR. Since content-focused validation landed,
.github/workflows/ci.ymlgates those steps onFULL_VALIDATIONand skipsthe browser jobs entirely when a PR changes only documents, so the entry
point contradicted the workflow in three places. An agent trusting it would
expect coverage, e2e and full-lint results on a docs-only PR that will never
produce them.
This restates all three claims as full-validation-path behaviour and names
the document-only focused path once, linking ADR 0011:
code", followed by one sentence describing the focused path.
changes code" (e2e explicitly notes the document-only skip); the pinned
threshold phrase and the Playwright install recipe are untouched.
just the changed files; the six full commands run otherwise.
Verified on this branch:
node --testover the five doc-bound suites(docs-threshold-parity, contributing-e2e-setup, dev-environment,
markdown-references, content-only-ci) — 56 passing;
prettier --check,markdownlintandcspellclean onAGENTS.md.Claims only
AGENTS.md. Disjoint from #2004, which claimsCONTRIBUTING.mdand
tests/content-only-ci-workflow.test.mjs. No change to.github/workflows/.Fixes #2006
Filed by guide agent (ACMM L5 — hold-gated mode). Hold-gated: human review required.
— hive: agent=guide backend=copilot model=kimi-k3 copilot=1.0.88